Skip to content

more utils, tests and docs #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2024
Merged

more utils, tests and docs #84

merged 3 commits into from
Oct 4, 2024

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Oct 4, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR primarily focuses on enhancing the testing framework and utility functions within the Thirdweb project, particularly around transaction handling, wallet operations, and gas estimation.

Detailed summary

  • Added tests for WaitForTransactionReceipt and PrepareTest methods.
  • Removed unused properties in ThirdwebChainBridge.
  • Introduced new utility methods for gas price and fees fetching.
  • Enhanced SmartWallet class with new methods for account management and session keys.
  • Improved error handling in wallet operations.
  • Updated tests for gas price and fees.
  • Refactored transaction handling for better clarity and functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 78.66667% with 48 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9f895d6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 79.56% 30 Missing and 8 partials ⚠️
Thirdweb/Thirdweb.Utils/Utils.cs 72.97% 7 Missing and 3 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage        ?   84.12%           
=======================================
  Files           ?       26           
  Lines           ?     3873           
  Branches        ?      531           
=======================================
  Hits            ?     3258           
  Misses          ?      480           
  Partials        ?      135

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 179904c into main Oct 4, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/utils-tests-docs branch October 4, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xFirekeeper @codecov-commenter